Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
==========================================
+ Coverage 92.89% 99.56% +6.67%
==========================================
Files 6 6
Lines 647 685 +38
==========================================
+ Hits 601 682 +81
+ Misses 46 3 -43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the threaded loop adapter implementation and enables Windows testing for previously skipped tests. The changes eliminate unnecessary Future/Deferred conversions and fix Windows compatibility issues.
Changes:
- Refactored threaded loop adapter to avoid unnecessary conversions between Deferred and Future objects
- Removed platform-specific test skips on Windows by properly managing the threaded loop lifecycle
- Extended CI to run pinned dependency tests on Windows
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/tests_asyncio/test_browser.py | Replaced platform.system() checks with @allow_windows decorator |
| tests/init.py | Updated @allow_windows to use test method ID and return Future result |
| scrapy_playwright/handler.py | Refactored to use _future_from_coro, moved signal connections after threaded loop setup, and relocated _ThreadedLoopAdapter.stop() calls |
| scrapy_playwright/_utils.py | Added _QueueItem dataclass, implemented _future_from_coro and _handle_coro_future methods, renamed parameters for clarity |
| pylintrc | Added too-many-lines to pylint disable list |
| .github/workflows/tests.yml | Added Windows-specific pinned dependency test jobs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.